Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Modifier #23

Merged
merged 30 commits into from
Oct 24, 2023
Merged

Conversation

SergioRibera
Copy link
Contributor

Create a new default modifier param and make keybind modifier optional, based on #9
Create test for the new parser of config

  • feature
  • tests

Note: after talking about this feature, I think this feature is necessary for future features.

lefthk/src/config.rs Outdated Show resolved Hide resolved
@AethanFoot
Copy link
Member

Ill give this a test asap

Copy link
Contributor

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions

lefthk/src/config.rs Outdated Show resolved Hide resolved
lefthk/src/config.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VuiMuich
Copy link
Member

Not enough time to fix the broken test rn, maybe later tonight.

@SergioRibera
Copy link
Contributor Author

@VuiMuich No problem, I'll check right away what is wrong with the CI processes and do some push to fix it

@VuiMuich
Copy link
Member

VuiMuich commented Oct 24, 2023

@VuiMuich No problem, I'll check right away what is wrong with the CI processes and do some push to fix it

Thanks for returning to this PR so promptly after that long time 😃

Nice idea to generate the normalized command from the raw string.

If you have a minute to cargo fmt that would be nice, otherwise I could also do this before merging.

@SergioRibera
Copy link
Contributor Author

Thanks for returning to this PR so promptly after that long time 😃

Of course, now I try to be more attentive to all this, I will be reviewing the project to see if I can find more I can collaborate.

If you have a minute to cargo fmt that would be nice, otherwise I could also do this before merging.

Oh no, I could have sworn I ran the corresponding commands before pushing, I'll fix it right away, thank you very much

@VuiMuich VuiMuich merged commit 80f16da into leftwm:main Oct 24, 2023
3 checks passed
@VuiMuich
Copy link
Member

Thanks for your contribution. If you have more to come this is surely welcome. Hopefully we don't have you waiting for the merge for so long again.

@SergioRibera SergioRibera deleted the feature/modifier_optional branch October 24, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants